search

magic-wormhole / magic-wormhole-mailbox-server

the rendezvous/mailbox server for magic-wormhole clients
MIT License
161 stars 34 forks source link

log_client_version failure in self._usage_db.execute #25

Closed kaie closed 2 years ago

kaie commented 2 years ago

Debian 10, installed versions magic-wormhole 0.11.2-1 magic-wormhole-transit-relay 0.1.2-1 python3-magic-wormhole-mailbox-server 0.3.1-2

Running wormhole with --transit-helper and --relay-url pointing to my own server.

Failure seen on mailbox-server:

  File "/usr/lib/python3/dist-packages/wormhole_mailbox_server/server.py", line 186, in log_client_version
    self._usage_db.execute("INSERT INTO `client_versions`"
builtins.AttributeError: 'NoneType' object has no attribute 'execute'

Apparently self._usage_db is undefined?

I hacked it to work by editing wormhole_mailbox_server/server.py and in function log_client_version I disabled the self._usage_db.execute() and self._usage_db.commit() calls (because I have the impression this is just for logging purposes, but not required for transfer functionality).

With these lines disabled, I can successfully transfer through my server.

kaie commented 2 years ago

I see you already fixed this with https://github.com/magic-wormhole/magic-wormhole-mailbox-server/commit/60c924a28c35370a9904bd63b28da49591aa92fb