Closed meejah closed 2 years ago
Base: 99.21% // Head: 99.22% // Increases project coverage by +0.00%
:tada:
Coverage data is based on head (
f0abdf7
) compared to base (80e02d4
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This pull request introduces 5 alerts when merging f0abdf7c28d782920ef41d0ff6c1ab898668517c into 80e02d4a77be5abfbca966d609408f6927cb3843 - view on LGTM.com
new alerts:
I'm not super happy with the test, because it's somewhat slow -- but since we already had a regression here I think on balance it's fine. But, maybe "integration-style" tests should go somewhere else -- or the test should be written in a more unit-style (although then it's harder to tell we're running the "real" transit)
Fixes #25
The refactorings that enabled WebSocket support missed the producer / consumer registration between sender and receiver.