At the moment, the tests send ./examples/example-file.bin and receive it as ./example-file.bin. The latter must stop, it's polluting the local repository and it's probably a source of impurity. It should be written to a temporary location instead.
While we're at it, maybe we can also remove ./examples/example-file.bin and instead generate it on the fly. Writing a few MB to /tmp won't hurt and probably is preferable over having that test data checked out.
That examples folder can then be removed, as its more a test than an example of how to use the API anyway. Adding useful examples is a story for another time. And test_file_rust2rust should cover all the functionality of that example anyways.
piegamesde
commented
3 years ago
At the moment, the tests send
./examples/example-file.binand receive it as./example-file.bin. The latter must stop, it's polluting the local repository and it's probably a source of impurity. It should be written to a temporary location instead.While we're at it, maybe we can also remove
./examples/example-file.binand instead generate it on the fly. Writing a few MB to/tmpwon't hurt and probably is preferable over having that test data checked out.That
examplesfolder can then be removed, as its more a test than an example of how to use the API anyway. Adding useful examples is a story for another time. Andtest_file_rust2rustshould cover all the functionality of that example anyways.