search

magic-wormhole / magic-wormhole.rs

Rust implementation of Magic Wormhole, with new features and enhancements
European Union Public License 1.2
722 stars 78 forks source link

Refactor send-many #117

Closed tau3 closed 3 years ago

tau3 commented 3 years ago

Hi! This PR closes #95

piegamesde commented 3 years ago

Woah, that's awesome, many thanks!

Please be patient for this to get merged however, my backlog is a bit full these days

piegamesde commented 3 years ago

Can you please rebase your changes on master?

tau3 commented 3 years ago

done. btw, looks like you have some broken unit tests in master (core::test::test_file_rust2rust)

piegamesde commented 3 years ago

Yeah, I fucked up, see https://github.com/magic-wormhole/magic-wormhole.rs/pull/116#issuecomment-804493278

piegamesde commented 3 years ago

I'm trying it out, and for some reason the help on that sub-command is empty? I can't tell any obvious cause for this though.

tau3 commented 3 years ago

it had been hidden by custom help message - fixed

piegamesde commented 3 years ago

I somehow always get a 'crowded' error from the server. But I also get this on master. I suspect that it's the same bug that's causing the tests to fail at the moment. Unless you want to work on this some more, I think I'll merge this now and then fix it together with the tests in the (hopefully) near future.