search

magic-wormhole / magic-wormhole.rs

Rust implementation of Magic Wormhole, with new features and enhancements
European Union Public License 1.2
722 stars 78 forks source link

More development #138

Closed piegamesde closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #138 (9b16a70) into master (035c4dc) will decrease coverage by 9.62%. The diff coverage is 16.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   64.39%   54.76%   -9.63%     
==========================================
  Files          14       15       +1     
  Lines        2022     2445     +423     
==========================================
+ Hits         1302     1339      +37     
- Misses        720     1106     +386
Impacted Files Coverage Δ
src/bin/main.rs 0.00% <0.00%> (ø)
src/forwarding.rs 0.00% <0.00%> (ø)
src/util.rs 28.57% <0.00%> (-4.16%) :arrow_down:
src/core.rs 81.02% <50.00%> (-2.95%) :arrow_down:
src/transfer.rs 42.85% <66.66%> (ø)
src/transit.rs 81.54% <86.07%> (+0.39%) :arrow_up:
src/transfer/messages.rs 79.31% <100.00%> (+1.53%) :arrow_up:
src/transfer/v1.rs 31.12% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 035c4dc...9b16a70. Read the comment docs.

Mic92 commented 2 years ago

Cool to see that port-forwarding is on the rise!

piegamesde commented 2 years ago

@Mic92 Actually, the development happens at #135, this PR was created to get some unrelated commits merged more quickly. The one remaining forwarding commit is only there because I was too lazy to resolve the conflicts from dropping it.

Functionally speaking, the port forwarding is mostly done. The next step would be to give the feature a proper API and good usability.