Closed andipabst closed 2 years ago
Merging #158 (8ce6278) into dev (496d94b) will decrease coverage by
6.59%
. The diff coverage is33.33%
.
@@ Coverage Diff @@
## dev #158 +/- ##
==========================================
- Coverage 52.39% 45.79% -6.60%
==========================================
Files 15 16 +1
Lines 2697 4804 +2107
==========================================
+ Hits 1413 2200 +787
- Misses 1284 2604 +1320
Impacted Files | Coverage Δ | |
---|---|---|
src/transit.rs | 80.27% <33.33%> (ø) |
|
src/core.rs | 79.08% <0.00%> (-2.08%) |
:arrow_down: |
src/lib.rs | 37.20% <0.00%> (ø) |
|
src/util.rs | 33.33% <0.00%> (+0.93%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 496d94b...8ce6278. Read the comment docs.
Thank you already. In the error handling commit, you forgot to make use of the RelayHandshakeFailed
variant. Also, please add #[cfg(not(target_family = "wasm"))]
to StunError
, PUBLIC_STUN_SERVER
and use ToSocketAddrs
to silence the compiler warnings. (I know you didn't introduce them, but GitHub renders them in a really annoying way if I fix them myself you't have to rebase again)
Thanks for the hints, I chanded the code accordingly :+1:
Thank you. Please note that I've moved the commits on the dev
branch to a new wasm
branch. Please use that for testing+contributing WASM support from now on. See also #161