search

magic-wormhole / magic-wormhole.rs

Rust implementation of Magic Wormhole, with new features and enhancements
European Union Public License 1.2
645 stars 72 forks source link

feature request: support ssh invite/ssh accept modes #182

Closed karlicoss closed 1 year ago

karlicoss commented 1 year ago

The python wormhole has ability to send/receive SSH keys. Any chance of supporting it here? Thanks!

piegamesde commented 1 year ago

Hi, that's most certainly a niche feature. I've never used it myself, so honestly I don't really know what the use case is here, especially why ssh-copy-id doesn't work out for you?

karlicoss commented 1 year ago

ssh-copy-id requires some method of authentication already set in place, wormhole comes very useful when you have passwordless-only ssh

piegamesde commented 1 year ago

But if you have a passwordless ssh connection, you're already done?

karlicoss commented 1 year ago

Not really, you might have it from a different computer, but not from the one you're trying to setup. Or you might have access to both machines physically, but no ssh keys shared between them yet.

On Mon, Feb 27, 2023, 10:29 piegames @.***> wrote:

But if you have a passwordless ssh connection, you're already done?

— Reply to this email directly, view it on GitHub https://github.com/magic-wormhole/magic-wormhole.rs/issues/182#issuecomment-1446076005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHEBLOE745E3ONVG3AX2TWZR6XDANCNFSM6AAAAAAVIXFJJQ . You are receiving this because you authored the thread.Message ID: @.***>

piegamesde commented 1 year ago

https://github.com/psanford/wormhole-william/issues/54

I agree with the discussion over there: ideally, wormhole-rs would handle this case sufficiently well without having to specially handle this exact use-case. And I acknowledge that this currently is not the case, given that currently there is no easy way to do shell redirects and such.

If you absolutely want the exact original functionality, I suggest writing a separate tool for that. wormhole-rs has a separate library component so it should not be any harder than implementing it in here.