search

magic-wormhole / magic-wormhole.rs

Rust implementation of Magic Wormhole, with new features and enhancements
European Union Public License 1.2
645 stars 72 forks source link

Add nameplates fn #184

Closed JustusFT closed 1 year ago

JustusFT commented 1 year ago

Ref: https://github.com/magic-wormhole/magic-wormhole.rs/issues/183

JustusFT commented 1 year ago

I updated the linked issue with more information about the use case. Currently I want the application to exit if the receiver put in a code with an unclaimed nameplate. Would it be better to include the nameplate validation inside connect_with_code so we don't need to call connect_custom? This would be similar to how wormhole-william does it

piegamesde commented 1 year ago

That would be okay to do, however it should be opt-in, as in most scenarios you actually don't want such a check.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.92 :tada:

Comparison is base (32369ac) 43.15% compared to head (3daaded) 44.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #184 +/- ## ========================================== + Coverage 43.15% 44.08% +0.92% ========================================== Files 18 18 Lines 2542 2552 +10 ========================================== + Hits 1097 1125 +28 + Misses 1445 1427 -18 ``` | [Impacted Files](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole) | Coverage Δ | | |---|---|---| | [cli/src/main.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-Y2xpL3NyYy9tYWluLnJz) | `0.00% <0.00%> (ø)` | | | [src/core/rendezvous.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL2NvcmUvcmVuZGV6dm91cy5ycw==) | `74.52% <87.50%> (+0.50%)` | :arrow_up: | | [src/core.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL2NvcmUucnM=) | `78.52% <100.00%> (+3.21%)` | :arrow_up: | | [src/transit/transport.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL3RyYW5zaXQvdHJhbnNwb3J0LnJz) | `86.59% <0.00%> (+2.06%)` | :arrow_up: | | [src/transit.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL3RyYW5zaXQucnM=) | `76.96% <0.00%> (+2.45%)` | :arrow_up: | | [src/core/server\_messages.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL2NvcmUvc2VydmVyX21lc3NhZ2VzLnJz) | `67.64% <0.00%> (+8.82%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

JustusFT commented 1 year ago

@piegamesde I squashed and rebased :+1: