search

magic-wormhole / magic-wormhole.rs

Rust implementation of Magic Wormhole, with new features and enhancements
European Union Public License 1.2
645 stars 72 forks source link

fix tarpaulin code coverage and add .vscode to gitignore #186

Closed jonZlotnik closed 1 year ago

jonZlotnik commented 1 year ago

the github action for tarpauling breaks often, and it's not worth depending on it when it's just as easy (and more transparent) to run it using the cargo action

evidence of frequent breakage: https://github.com/actions-rs/tarpaulin/issues/15 https://github.com/actions-rs/tarpaulin/pull/23

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 72.64% and project coverage change: +0.08 :tada:

Comparison is base (5778854) 43.18% compared to head (131ca58) 43.27%.

:exclamation: Current head 131ca58 differs from pull request most recent head e232c74. Consider uploading reports for the commit e232c74 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #186 +/- ## ========================================== + Coverage 43.18% 43.27% +0.08% ========================================== Files 17 18 +1 Lines 2554 2542 -12 ========================================== - Hits 1103 1100 -3 + Misses 1451 1442 -9 ``` | [Impacted Files](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole) | Coverage Δ | | |---|---|---| | [src/forwarding.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL2ZvcndhcmRpbmcucnM=) | `0.00% <0.00%> (ø)` | | | [src/transit/crypto.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL3RyYW5zaXQvY3J5cHRvLnJz) | `43.26% <12.00%> (-6.08%)` | :arrow_down: | | [src/transfer/v1.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL3RyYW5zZmVyL3YxLnJz) | `34.34% <50.00%> (-0.44%)` | :arrow_down: | | [src/transfer.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL3RyYW5zZmVyLnJz) | `40.20% <75.00%> (-1.10%)` | :arrow_down: | | [src/util.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL3V0aWwucnM=) | `37.25% <80.00%> (+1.83%)` | :arrow_up: | | [src/transit.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL3RyYW5zaXQucnM=) | `75.24% <80.59%> (-0.86%)` | :arrow_down: | | [src/transit/transport.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL3RyYW5zaXQvdHJhbnNwb3J0LnJz) | `84.53% <84.53%> (ø)` | | | [src/core/rendezvous.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL2NvcmUvcmVuZGV6dm91cy5ycw==) | `74.01% <100.00%> (+0.98%)` | :arrow_up: | | [src/transfer/messages.rs](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL3RyYW5zZmVyL21lc3NhZ2VzLnJz) | `55.55% <0.00%> (-3.07%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/186?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jonZlotnik commented 1 year ago

wow... I'm terrible at git restarting in a new PR