search

magic-wormhole / magic-wormhole.rs

Rust implementation of Magic Wormhole, with new features and enhancements
European Union Public License 1.2
645 stars 72 forks source link

cargo: Update dependencies #205

Closed felinira closed 10 months ago

felinira commented 10 months ago

Replace xsalsa20poly1305 with crypto_secretbox: https://rustsec.org/advisories/RUSTSEC-2023-0037.html Update webpki: https://rustsec.org/advisories/RUSTSEC-2023-0052.html

Closes #204 #197

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 69.23% and project coverage change: -0.24% :warning:

Comparison is base (8f379b7) 40.52% compared to head (d577f3b) 40.29%.

:exclamation: Current head d577f3b differs from pull request most recent head 7810529. Consider uploading reports for the commit 7810529 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #205 +/- ## ========================================== - Coverage 40.52% 40.29% -0.24% ========================================== Files 23 23 Lines 3326 3318 -8 ========================================== - Hits 1348 1337 -11 - Misses 1978 1981 +3 ``` | [Files Changed](https://app.codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole) | Coverage Δ | | |---|---|---| | [src/core.rs](https://app.codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL2NvcmUucnM=) | `72.92% <ø> (-1.27%)` | :arrow_down: | | [src/util.rs](https://app.codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL3V0aWwucnM=) | `31.91% <0.00%> (-5.20%)` | :arrow_down: | | [src/core/key.rs](https://app.codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL2NvcmUva2V5LnJz) | `98.61% <100.00%> (ø)` | | | [src/core/server\_messages.rs](https://app.codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL2NvcmUvc2VydmVyX21lc3NhZ2VzLnJz) | `67.64% <100.00%> (ø)` | | | [src/transit/crypto.rs](https://app.codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole#diff-c3JjL3RyYW5zaXQvY3J5cHRvLnJz) | `41.84% <100.00%> (-1.42%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/magic-wormhole/magic-wormhole.rs/pull/205/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=magic-wormhole)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

felinira commented 10 months ago

According to CI this needs an MSRV bump to 1.67

https://github.com/magic-wormhole/magic-wormhole.rs/actions/runs/6136864340/job/16652120206#step:6:140

error: package `time v0.3.28` cannot be built because it requires rustc 1.67.0 or newer, while the currently active rustc version is 1.66.0
felinira commented 10 months ago

1.70, even. Why can't it tell me in the first place, oh well.

error: package `async-tungstenite v0.23.0` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.67.0
piegamesde commented 10 months ago

Thank you