search

magic-wormhole / magic-wormhole.rs

Rust implementation of Magic Wormhole, with new features and enhancements
European Union Public License 1.2
645 stars 72 forks source link

code: Fix warnings #212

Closed felinira closed 4 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 41.66667% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 40.34%. Comparing base (6b11a4c) to head (0f95f5d). Report is 2 commits behind head on master.

Files Patch % Lines
src/transfer/v2.rs 0.00% 10 Missing :warning:
cli/src/main.rs 0.00% 8 Missing :warning:
src/transfer.rs 20.00% 4 Missing :warning:
src/transfer/v1.rs 0.00% 4 Missing :warning:
src/transit/crypto.rs 0.00% 4 Missing :warning:
src/forwarding.rs 0.00% 2 Missing :warning:
cli/src/util.rs 0.00% 1 Missing :warning:
src/core.rs 88.88% 1 Missing :warning:
src/transit.rs 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #212 +/- ## ========================================== + Coverage 40.05% 40.34% +0.29% ========================================== Files 23 23 Lines 3298 3294 -4 ========================================== + Hits 1321 1329 +8 + Misses 1977 1965 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

felinira commented 7 months ago

I'm really confused by the CI failures, it builds fine for me with (presumably?) the same options and the same targets?

felinira commented 4 months ago

I'm really confused by the CI failures, it builds fine for me with (presumably?) the same options and the same targets?

Answer to myself from myself from the future: This had apparently bumped the MSRV to 1.74. I would consider this to be something we might want to be doing anyway so I just bumped it to 1.75, for all the async improvements that landed in 1.75.