Closed felinira closed 1 month ago
Attention: Patch coverage is 19.04762%
with 17 lines
in your changes missing coverage. Please review.
Project coverage is 38.13%. Comparing base (
00c3ef9
) to head (9b99548
).
Files | Patch % | Lines |
---|---|---|
src/core.rs | 16.66% | 10 Missing :warning: |
cli/src/main.rs | 0.00% | 5 Missing :warning: |
src/forwarding.rs | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
These struct fields were public, and therefore modifiable if you have a mutable reference to them. However their purpose is to expose connection state for apps to consume, not to be changeable during the connection, which could lead to strange behaviour, or be at the very least confusing.
This makes them private and exposes them via getters.