magic-wormhole / magic-wormhole.rs

Rust implementation of Magic Wormhole, with new features and enhancements
European Union Public License 1.2
722 stars 78 forks source link

Fix dual-stack socket usage on Windows #247

Closed himikof closed 1 month ago

himikof commented 1 month ago

The transport code has a hard dependency on dual-stack sockets (using IPv4-mapped IPv6 addresses). Those sockets only work if IPV6_V6ONLY socket option is unset. Unfortunately, the default value for this option is not always false:

Set this option explicitly to ensure the socket will work regardless of the default value.

It could be the underlying reason for #168.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.95%. Comparing base (5279161) to head (3c987e9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #247 +/- ## ========================================== - Coverage 38.03% 37.95% -0.08% ========================================== Files 18 18 Lines 3163 3164 +1 ========================================== - Hits 1203 1201 -2 - Misses 1960 1963 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

felinira commented 1 month ago

Thanks a lot :)