Windows release binary as an executable and not as an archive

magic-wormhole / magic-wormhole.rs

Rust implementation of Magic Wormhole, with new features and enhancements

European Union Public License 1.2

738 stars 80 forks source link

Windows release binary as an executable and not as an archive #263

Open kernelPanic0x opened 2 days ago

kernelPanic0x commented 2 days ago

What is the reason for the windows binary release to be .tgz? Wouldn't it be easier if the downlaod would be an executable right away? I am not sure if all windows users are familiar with .tar.gz files 😆.

felinira commented 18 hours ago

The linux binaries are in a .tar.gz file because they need to preserve the executable bit. I don't know about windows, but I want to stay compatible to cargo-binstall. Considering https://github.com/xd009642/tarpaulin/releases also has a zip file on windows, we could probably use zip instead.

felinira commented 18 hours ago

Contributions to change the CI to build zip files on windows would be accepted. I suppose we could be using https://github.com/taiki-e/upload-rust-binary-action which seems to do this automatically.