search

magicDGS / ReadTools

A Universal Toolkit for Handling Sequence Data from Different Sequencing Platforms
https://magicdgs.github.io/ReadTools/
MIT License
6 stars 3 forks source link

Force locale to english on tests #483

Closed magicDGS closed 6 years ago

magicDGS commented 6 years ago

GATK's uses Utils.forceJVMLocaleToUSEnglish on startup to maintain consistency for computers with different local configuration (e.g., decimal format with dots/commas might differ). Because this is a static call in their main class, our downstream class is not picking this configuration (that's very bad); thus, we should add it as a short-term fix and do a PR to GATK to make it easier to pick by downstream tools.

magicDGS commented 6 years ago

I was wrong about our main not getting the locale properly (I did a quick test that I would not push to the repo) - thus, only the base test should be statically calling the method.