Tests failing in windows due to line endings

magicDGS / jsr203-http

**Under development** HTTP/S FileSystem provider for Java NIO.2

BSD 3-Clause "New" or "Revised" License

2 stars 2 forks source link

Tests failing in windows due to line endings #39

Closed magicDGS closed 6 years ago

magicDGS commented 6 years ago

If using git for Windows, the EOL is converted and thus tests relying on reading all bytes from a file are not working. There are two possibilities to fix this problem:

Change tests to do not check bytes but lines, removing the system-specific EOL.
Add .gitattributes specific for the docs folder, where the line endings are kept as they are (also important for formatting docs, I guess)

In addition, we should test this on the CI (see #38)

magicDGS commented 6 years ago

Maybe useful: http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/

magicDGS commented 6 years ago

After adding the AppVeyor-CI, this is failing only locally. Thus, this should be fixed on my local computer and not at the repository level. Nevertheless, it would be nice to have a test for allowing also windows users to download with the configuration of Windows Git which change line endings...

magicDGS commented 6 years ago

Closing in favor of recommendations for Windows (#43). Changing to do not check line endings sounds wrong to me, because it can introduce bugs in compressed files if tested at some point.