search

magicDGS / jsr203-http

**Under development** HTTP/S FileSystem provider for Java NIO.2
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Use gitattributes to handle EOL in Windows tests #42

Closed magicDGS closed 6 years ago

magicDGS commented 6 years ago

Fixes #39

codecov-io commented 6 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #42   +/-   ##
=========================================
  Coverage     78.74%   78.74%           
  Complexity       96       96           
=========================================
  Files             8        8           
  Lines           287      287           
  Branches         42       42           
=========================================
  Hits            226      226           
  Misses           50       50           
  Partials         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7149c06...17f3b9d. Read the comment docs.

magicDGS commented 6 years ago

Won't fix like this, because it is wrong. I think that we should just make guidelines for how to clone the repository in windows and a warning about end of lines, or make the tests not aware of eol.