magicDGS / jsr203-http

**Under development** HTTP/S FileSystem provider for Java NIO.2

BSD 3-Clause "New" or "Revised" License

2 stars 2 forks source link

Updating build to gradle 6.1 and adding publishing options. #61

Open lbergelson opened 4 years ago

lbergelson commented 4 years ago

Updating gradle from 4.9 -> 6.1
Updating from using java plugin -> java-library plugin
Adding publishing section to build to allow publishing to local and remote repositories

I've added a publishing section that publishes to the same places that most broad projects are published. This is more a proof of concept than a working option since you might have different publishing targets. I've tested publishing to the broad artifactory with my credentials and that works, as does publishing to maven local. I haven't / can't publish to sonatype because I don't control the org.magicdgs namespace.

I edited the version a bit to drop the .dirty and add SNAPSHOT when relevant. Happy to make whatever changes you prefer though. The snapshot bit is necessary I think for dealing with maven snapshot repositories but removing dirty is not important.

I need to add publishing options so I can make it easy to test against gatk.

lbergelson commented 4 years ago

Tests are failing because travis no longer offers oraclejdk8 on the newer vms. I think we can fix this by pegging ourselves to an old version of ubuntu, but the best/easiest thing is probably to just switch to testing on openjdk8. The newest versions of oracle jdk 8 require a restrictive license and the old versions are only available with an oracle login, so it's pretty annoying.

codecov-io commented 4 years ago

Codecov Report

Merging #61 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage     84.36%   84.36%           
  Complexity      126      126           
=========================================
  Files             8        8           
  Lines           339      339           
  Branches         60       60           
=========================================
  Hits            286      286           
  Misses           42       42           
  Partials         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e20eec...359ed30. Read the comment docs.

magicDGS commented 4 years ago

@lbergelson, thanks for starting with the contribution/collaboration!

First, could you please separate (in two PRs) the publishing from the gradle update? I have to think about publishing strategy/coordinates in maven and thus we can leave that for a different PR to discuss there.

In addition, I'd like to keep the dirty marker when a build is done with changes in the local repository (should not happen on the CI build) to be sure that it's not coming from committed changes. The SNAPSHOT is a good addition, as I am planning to keep snapshots from master until a realease is done.

lbergelson commented 4 years ago

@magicDGS I've removed the publishing bit and kept the "dirty" status.

lbergelson commented 4 years ago

@magicDGS Updated

lbergelson commented 4 years ago

@magicDGS I think I addressed your comments, let me know if you have more.