search

magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!
Other
10.8k stars 1.79k forks source link

Update MagicalRecord.podspec #1101

Closed melbic closed 8 years ago

melbic commented 8 years ago

Fixing Issue: https://github.com/magicalpanda/MagicalRecord/issues/988

I didn't test what happens if CocoaLumberjack wasn't used in a project...

tonyarnold commented 8 years ago

I didn't test what happens if CocoaLumberjack wasn't used in a project...

Any chance that you could? I'm not going to have time to test this for a week or so.

melbic commented 8 years ago

I don't know if I'll find time for it this week, but I'll try.

melbic commented 8 years ago

Sometimes you have to take the time. But it actually doesn't work. It fails with:

ld: framework not found CocoaLumberJack
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I didn't find a way to add the framework as optional.

tonyarnold commented 8 years ago

What I'd say we have to do is add a "MagicalRecord+CocoaLumberjack" subspec that users can chose to use over the standard "MagicalRecord" one. That subspec could link in CL.

melbic commented 8 years ago

I added a Subspec, so the version with CocoaLumberjack as dependency can be installed with: pod "MagicalRecord/CocoaLumberjack"

scottrhoyt commented 8 years ago

Can we get this pulled? I think there's a few of us waiting on this one. Thanks!

bpoplauschi commented 8 years ago

This update should be propagated to the CocoaPods/Specs repo so we all get it.

lolgear commented 8 years ago

done?

bpoplauschi commented 8 years ago

Guys, you need to make this update to Cocoapods/Specs. We cannot make it. Apparently, only Saul Mora and Tony Arnold can.