search

magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!
Other
10.8k stars 1.79k forks source link

Added autoselect of the default spec based on the CocoalLumberjack availability #1132

Closed anton-matosov closed 8 years ago

anton-matosov commented 8 years ago

Fix for #988 as addition to #1101

tonyarnold commented 8 years ago

Does this actually work? Those look like C defines, not Ruby defines — also the podspec is converted to JSON when you submit to trunk.

Can you point me at the CocoaPods documentation for this feature please :smile:

anton-matosov commented 8 years ago

No. It doesn't... you are right. I have used changes from https://github.com/rivera-ernesto/MagicalRecord/commit/208b3b407bc5d9105e8e7e60a5f5189955f5e92c but I didn't pay attention that they are content of the pre-compiled header... and with my changes I was simply overriding the default subspec...

anton-matosov commented 8 years ago

So it is incorrect change.

tonyarnold commented 8 years ago

Thanks for the time you put into this all the same. I appreciate you wanting to improve MR :)

anton-matosov commented 8 years ago

you are welcome =)