search

magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!
Other
10.8k stars 1.79k forks source link

Added MagicalRecordShorthandMethodAliases.h to private headers so it … #1133

Closed anton-matosov closed 8 years ago

anton-matosov commented 8 years ago

…is not getting included into umbrealla header and enabled by default in swift

tonyarnold commented 8 years ago

Looks fine to me, however are the shorthand methods still usable for CocoaPods users when this header is marked private? (manually linking in the header)

anton-matosov commented 8 years ago

It should. Let me double check.

anton-matosov commented 8 years ago

It didn't work with frameworks, so I had to use excludes instead of private headers and create a 'Shorthands' subspec to be able to still include them. Although i had to rework it, this approach looks better as it works natively with frameworks and can be used with CocoaLumberjack subspec. Usage examples:

No shorthands:

  pod 'MagicalRecord'

With shorthands:

  pod 'MagicalRecord'
  pod 'MagicalRecord/Shorthands'

With CocoaLumberjack and shorthands:

  pod 'MagicalRecord/CocoaLumberjack'
  pod 'MagicalRecord/Shorthands'
anton-matosov commented 8 years ago

I can't reproduce crash of the test in dev environment.

tonyarnold commented 8 years ago

I've merged this in as 2cc8027b307b46a623cf4c5e76fc15e3b3fb9890 with the subspec name MagicalRecord/ShorthandMethodAliases. Thanks for the PR!