search

magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!
Other
10.8k stars 1.79k forks source link

Enable much stricter warnings, and turn on warnings as errors #1135

Closed tonyarnold closed 8 years ago

tonyarnold commented 8 years ago

So this might be a bit contentious, but I'd like to tidy up MR 3 for release at the same time as modernising as much as possible.

Not sure you're going to agree with all of this, @casademora, but it has helped me to write better code (and I'm hoping it will help as I walk through and fix a few things).

casademora commented 8 years ago

Wha? You removed the oxford semi-colons? 😓

casademora commented 8 years ago

Over all I'm ok with the changes. It looks like they make the code more consistent and well named, so I'm all for it. Huge thanks to @tonyarnold for this! 🎊🎉

tonyarnold commented 8 years ago

I know you were fond of the semicolons, but it was time dude.

tonyarnold commented 8 years ago

@casademora if you're happy for me to merge this in, let's do it and then merge this into master. It's time to focus development on 3.0.

magicalpandatest commented 8 years ago

I cling to the traditions of my ancestors…

On Nov 17, 2015, at 11:21 AM, Tony Arnold notifications@github.com wrote:

I know you were fond of the semicolons, but it was time dude.

— Reply to this email directly or view it on GitHub https://github.com/magicalpanda/MagicalRecord/pull/1135#issuecomment-157476768.

tonyarnold commented 8 years ago

I BBQ'ed my ancestors in a purifying :fire:, then ate them with some chunky steak fries