search

magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!
Other
10.8k stars 1.79k forks source link

NSConfinementConcurrencyType deprecated #1143

Open jordanbigel opened 8 years ago

jordanbigel commented 8 years ago

The concurrencyType constant "NSConfinementConcurrencyType" has been deprecated in iOS9. It is used throughout MR in a half dozen or more places. The only other options are private and main thread types. Which should we be using, or is the concurrency type variable?

Will there be a new MR release soon which does not use the deprecated type? Thanks.

tonyarnold commented 8 years ago

I've started cleaning up the release/3.0 branch to this end, but I haven't finished that work. It's not a straight upgrade from 2.x to 3.x either — a number of key things have changed (hence the 3.x).

jordanbigel commented 8 years ago

Excellent - thanks! I am using 3.0 branch already, and it is working great (under tvOS). But some warnings, like the one I highlighted here. I'm hoping to submit my tvOS app to apple in about 8 weeks, I am only about 2 weeks into it so far. THANKS AGAIN TONY!

tonyarnold commented 8 years ago

I think what we probably need to do here is to deprecate the confinement concurrency type for 3.0 (given 3.0 is still targeting iOS 8 / OS X 10.10) and move all of the standard methods to use the private queue type. I've made a start on this in a local branch, but it might take a little time.

pronebird commented 8 years ago

@tonyarnold MagicalRecordStack only has newConfinementContext, it would be awesome to have similar method that could create private or main concurrency queues configured for use with stack's persistent coordinator.

tonyarnold commented 8 years ago

@pronebird I've started work toward this in the fix/3.0-concurrency-debug branch. I've added the basic methods, but no tests, and none of the stacks really use them properly. There's a fair bit of work to this.