Fixes crash when importing object with no 'primaryAttribute' in Swift

magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!

Other

10.8k stars 1.79k forks source link

Fixes crash when importing object with no 'primaryAttribute' in Swift #1148

Closed AnthonyMDev closed 8 years ago

AnthonyMDev commented 8 years ago

Magical Record 2.x is causing a crash when trying to bridge a nil primaryAttribute to Objective-C.

This prevents the crash with no functional changes to the library.

See for more info: http://stackoverflow.com/questions/32514819/mr-importfromobject-method-is-not-working-in-xcode7-1-beta-swift-2-0

tonyarnold commented 8 years ago

Sorry about the open/close @AnthonyMDev — I'm trying to get TravisCI to pick up this is here so I can merge it.

AnthonyMDev commented 8 years ago

@tonyarnold Is this ever going to get pulled? I know your CI has been having issues, but it seems like these issues have been going on for far too long to continue to halt and development changes.

tonyarnold commented 8 years ago

Hi @AnthonyMDev — I haven't been working on MR this past few weeks. I've just rolled your fix in manually in efc25ef8a6973ff1532e106979232cd6beceb435, as this PR seems stuck in limbo (TravisCI is ignoring this PR, and there are merge conflicts).