search

magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!
Other
10.8k stars 1.79k forks source link

watchOS updates! #1208

Closed stury closed 5 years ago

stury commented 8 years ago

These are small changes needed to compile MagicalRecord on watchOS! We need this for getting our app engine to run on watchOS.

ekimia commented 8 years ago

bump - if we have eyes to get this in it would be extremely useful

casademora commented 8 years ago

I'll take a look at this soon. thanks for submitting this...

ekimia commented 8 years ago

awesome, if it checks out i can update it with master unless @stury beats me to it

stury commented 8 years ago

I’d love it if you would incorporate it into the master! We’re using a fork of MagicalRecord until this gets into the main release.

Shouldn’t be much to do to get this working on tvOS as well.

Thanks!

Scott Tury

On May 17, 2016, at 11:30 PM, Evan Kimia notifications@github.com wrote:

awesome, if it checks out i can update it with master unless @stury https://github.com/stury beats me to it

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/magicalpanda/MagicalRecord/pull/1208#issuecomment-219916405

casademora commented 8 years ago

Well, I'm trying to get back into everything after lots of craziness...thanks for being patient...

jasonscharff commented 8 years ago

Will this be merged soon?

stury commented 7 years ago

Interesting, I did not notice the "all checks have failed" on this PR. I just took a look at the log for the checks, and it looks like it's only failure is for code signing. Has anyone checked the travis setup to make sure you can code sign the appropriate parts? 

Check dependencies
Code Sign error: No code signing identities found: No valid signing identities (i.e. certificate and private key pair) were found.
lexin commented 7 years ago

So. Do we have ability to use MagicalRecord with watchOS? Can't find true link.

stury commented 7 years ago

I'm not sure why the automated merging of this PR is not working. It seems to be a configuration issue with the current setup.

There are a few things that are not available on watchOS. But unless you're using those specific features, you should be good to go to use MagicalRecord on watchOS - as well as tvOS!

I'm using my updates in multiple projects at the moment on watchOS and tvOS. You can get my fork of the MagicalRecord code at https://github.com/stury/MagicalRecord . I'd love for it to be integrated into the main codebase though!

lexin commented 7 years ago

Great! Thank you, stury. I successfully installed it from your git.

Coeur commented 5 years ago

tvOS doesn't support NSPersistentStoreUbiquitousContentURLKey, so testing for #ifndef TARGET_OS_WATCH is not enough.

Coeur commented 5 years ago

I've done the relevant code change for watchOS compatibility on master (see #1362). Now I just need to add the targets.

stury commented 5 years ago

Thank You!

On Jun 20, 2019, at 6:46 AM, Antoine Cœur notifications@github.com wrote:

I've done the relevant code change for watchOS compatibility on master (see #1362 https://github.com/magicalpanda/MagicalRecord/pull/1362). Now I just need to add the targets.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magicalpanda/MagicalRecord/pull/1208?email_source=notifications&email_token=AAJLFWHD5FU4G2RZLO6HFBTP3NNWVA5CNFSM4B64KZS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYFBLPA#issuecomment-503977404, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJLFWAM27CQWS7XKKAABCLP3NNWVANCNFSM4B64KZSQ.

Coeur commented 5 years ago

Done in #1363