magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!
Other
10.8k stars 1.8k forks source link

Test to prove sort flags are honoured when passing sort descriptors into `MR_requestAllSortedBy:ascending:withPredicate:inContext:` #1251

Closed deanWombourne closed 5 years ago

deanWombourne commented 7 years ago

Morning.

This should fix issue #1245

Thanks!

deanWombourne commented 7 years ago

OK, this build is failing in travis because it can't code sign :|

AFAIK My test is constructed exactly the same as the other tests , and the project configuration is unchanged apart from adding my test file to the test targets (the same 4 targets as the other tests) so I don't know why this commit is failing.

Annoyingly, the test itself seems to pass fine.

Coeur commented 5 years ago

@deanWombourne signing issues are now fixed on master, so you may rebase your pull request. Thank you.

Coeur commented 5 years ago

Thank you, but I don't have the access permissions to merge with the CI previously failing, and you didn't rebase it, so this issue will be handled by #1370 instead.