search

magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!
Other
10.8k stars 1.79k forks source link

Carthage built magical record framework version shown as app's [tag_name] in Info.plist #1274

Open tharindu opened 7 years ago

tharindu commented 7 years ago

Looks like building MagicalRecord via Carthage and submitting apps have following error.

error error_2
Coeur commented 5 years ago

Is it still happening with MagicalRecord 2.3.3 or 2.4.0 and latest Carthage?

tharindu commented 5 years ago

Yes. It still shows the last tag name of my personal repository in Magical Record framework's Info.plist. Since my tag name is with string characters it is not a valid number. Updated to latest version and tested too 2.4.0. So I have to manually update the Info.plist file of Magical Record framework version into a valid number after carthage update --platform iOS

suniljakhar commented 4 years ago

Is this issue still exist?

Coeur commented 4 years ago

@suniljakhar I'm not a Carthage user, so you'll have to make a pull request eventually.