search

magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!
Other
10.8k stars 1.8k forks source link

Importing MagicalRecord+ShorthandMethods.h in MagicalRecord.h - Issue 1276 #1281

Open amleszk opened 7 years ago

amleszk commented 7 years ago

1276

Coeur commented 5 years ago

Thank you.

  1. I couldn't reproduce any compilation error, as written in the linked issue (#1276).
  2. Changing #import <MagicalRecord/MagicalRecord.h> to #import <MagicalRecord/MagicalRecordInternal.h> is nice, so I'm cherry picking it in #1350.
  3. As for adding #import <MagicalRecord/MagicalRecord+ShorthandMethods.h> in the umbrella header, I don't know. It wasn't there for the past 3 years. Currently, I don't even know what is this enableShorthandMethods, so I would need more enlightening regarding its usage and usefulness. I'll leave the Pull Request open, but with a different title.