search

magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!
Other
10.8k stars 1.79k forks source link

Fix testSaveToPersistentStoreWhenSaveIsSynchronous #1354

Closed Coeur closed 5 years ago

Coeur commented 5 years ago

I believe that the entity was released before we could check for hasChanges.

performBlockAndWait: was added to the test on master (2.3.0) branch by ecb4efebee38f6b08d7104f182aa7645525d9f5d (Oct 4, 2014), but it was never added to the 3.0 branch.

[edit]

Actually, performBlockAndWait: was also added to branch maintenance/3.0, as of https://github.com/magicalpanda/MagicalRecord/pull/1293/commits/bb442d185c562c3f5b4130f28e761067ac1e27b9.

Coeur commented 5 years ago

I'll assume that my modification is not biasing the test.