search

magicalpanda / MagicalRecord

Super Awesome Easy Fetching for Core Data!
Other
10.79k stars 1.79k forks source link

CFBundleShortVersionString is missing when Framework gets compiled from sources #1373

Closed pertau closed 5 years ago

pertau commented 5 years ago

When Carthage needs to build from sources, the CFBundleShortVersionString is missing.

In our case we were reaching the API rate limit for Github on our CI, so it skipped downloading the binary and just compiled from sources.

Coeur commented 5 years ago

Please provide a pull request.

pertau commented 5 years ago

It happened on our CI which used carthage, configured in cartfile use v2.3.3.

Lets see what happens if I set up carthage to build from master and then verify if it happens again when I choose tag v2.3.3

pertau commented 5 years ago

It`s interesting, i can't reproduce it. will close this issue.