In the company I work with we use MagicalRecord and Carthage as a dependency manager. Due to this problem, we had to fork the repository with the modification described because we used tags in git in the following format: beta/202010111458 and when compiling MagicalRecord, this text was like CFBundleShortVersionString and resulted in the issue "This bundle is The value for key CFBundleShortVersionString 'beta/202010111458' in the Info.plist file must be a period-separated list of at most three non-negative integers.".
So this modification in the set_version_information.sh script solves the problem and I think it might be interesting for other projects that use lib, as described in the issue #1259.
Anyway, this PR is one of my contributions for Hacktoberfest 2020, so even if it's not merged, I would love it if a maintainer could add the hacktoberfest-accepted tag in PR if it is an interesting contribution. 😄
In the company I work with we use MagicalRecord and Carthage as a dependency manager. Due to this problem, we had to fork the repository with the modification described because we used tags in git in the following format:
beta/202010111458and when compiling MagicalRecord, this text was like CFBundleShortVersionString and resulted in the issue"This bundle is The value for key CFBundleShortVersionString 'beta/202010111458' in the Info.plist file must be a period-separated list of at most three non-negative integers.".So this modification in the
set_version_information.shscript solves the problem and I think it might be interesting for other projects that use lib, as described in the issue #1259.Anyway, this PR is one of my contributions for Hacktoberfest 2020, so even if it's not merged, I would love it if a maintainer could add the
hacktoberfest-acceptedtag in PR if it is an interesting contribution. 😄