search

magicalraccoon / tootstream

A command line interface for interacting with Mastodon instances
MIT License
259 stars 32 forks source link

Upgrade to colored 1.3.5 #142

Closed ddevault closed 6 years ago

ddevault commented 6 years ago

And ideally don't pin the version, please.

craigmaloney commented 6 years ago

I just took a peek at the latest version of colored (1.3.5) and it looks like the changes are minor. I can update this.

Though I'm curious what prompted this issue? Did something not work or act strange?

Thanks!

ddevault commented 6 years ago

When you pin versions and your dependencies update, your software won't work if the package is installed system-wide instead of a virtualenv. Virtualenvs are an anti-pattern.

ddevault commented 6 years ago

Better to use >= than ==

ddevault commented 6 years ago

Also, click is now on version 6.7.

craigmaloney commented 6 years ago

Right, but we've also had instances where updating to Mastodon.py had backward-incompatible changes. So we've done version pinning in order to prevent breakage until we have things sorted.

Anti-pattern or not there's some thought behind both of our reasoning.

ddevault commented 6 years ago

I think it'd be better to let it break and have users come around with bug reports. I would also submit your concerns to Mastodon.py. Your other dependencies are a bit more venerable, I wouldn't worry about them.

craigmaloney commented 6 years ago

I've updated the requirements.txt and have only pinned Mastodon.py (for now). I think Mastodon 1.1.2 is "just around the corner" (tm) so will test then to see if it causes issues.

Will test this out and may release this proper in 0.3.1 (or 0.4.0, depending on how quickly we can merge profile support).

Thanks!

ddevault commented 6 years ago

Thanks!