search

magicalraccoon / tootstream

A command line interface for interacting with Mastodon instances
MIT License
259 stars 32 forks source link

Loosen Mastodon.py requirements slightly to allow usage of 1.4.6 #213

Closed kmosiejczuk closed 5 years ago

kmosiejczuk commented 5 years ago

Loosen Mastodon.py requirements slightly to allow usage of 1.4.6 and other versions before 1.5.0

craigmaloney commented 5 years ago

I've resisted the temptation to loosen up the requirements for a specific version of Mastodon.py because there have been instances where a minor release has introduced breaking changes. That said it also means we've added an extra maintenance burden whenever there's a bug fix release of Mastodon.py. Is there anything in particular that 1.4.6 adds that would warrant supporting it and making a new release?

kmosiejczuk commented 5 years ago

There's no real need for a new release to support 1.4.6. It seems to be just documentation fixes. The past couple releases seemed to be minor bugfixes so I thought I'd see about loosening the requirements to make it easier. I am the maintainer of the OpenBSD port of tootstream and am integrating this patch. Right now the maintainer of mastodon.py is forced into lockstep with me. This allows them to at least check if the new version breaks tootstream. I suppose for most of your user base though this adds the risk they won't be able to install a working version.

craigmaloney commented 5 years ago

OK. I think we can take a chance on this. I'll approve the pull request soon (am not in front of a machine that will let me do it at the moment).

Will reconsider this if we suddenly get reports of breakage. :)

Thanks!