Closed magicant closed 1 month ago
The recent changes in the yash-env
project primarily enhance the signal handling capabilities in the system
module. The introduction of the SigmaskOp
type replaces the previous SigmaskHow
enum, streamlining signal mask operations. This transition improves clarity, maintainability, and type safety across various implementations, including RealSystem
, VirtualSystem
, and their related components.
Files | Change Summary |
---|---|
yash-env/system.rs , yash-env/system/real.rs , yash-env/system/select.rs , yash-env/system/shared.rs , yash-env/system/virtual.rs , yash-env/src/system/virtual/process.rs |
Replaced SigmaskHow with SigmaskOp in sigmask method signatures and internal logic, improving clarity and expressiveness for signal operations. Updated corresponding test cases to reflect these changes. |
yash-env/src/subshell.rs |
Modified MaskGuard to use SigmaskOp for signal masking, enhancing clarity and extensibility. |
yash-env/CHANGELOG.md |
Summarized significant updates and structural changes across the system module, including type relocations and method modifications. |
sequenceDiagram
participant User
participant System
participant Process
User->>System: Request sigmask operation
System->>Process: Execute sigmask with SigmaskOp
Process-->>System: Return updated signal mask
System-->>User: Signal mask updated
🐰 In the meadow, a change so bright,
New signals dance in morning light.
WithSigmaskOp
, they play and sway,
Enhancing the code in a joyful way.
Hopping toward clarity, our code takes flight,
A happy rabbit sings of this delight! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This is part of #353.
This pull request replaces the
nix::sys::signal::SigmaskHow
enum with the newyash_env::system::SigmaskOp
enum.Summary by CodeRabbit
New Features
SigmaskOp
type for enhanced signal masking operations, replacing the previousSigmaskHow
type, simplifying and clarifying signal handling.System
trait with new methods for improved functionality in handling user and system signals.Bug Fixes
Documentation
SigmaskOp
operations.Tests