search

magicant / yash

Yet another shell
http://magicant.github.io/yash/
GNU General Public License v2.0
346 stars 30 forks source link

Allow configuring predict style through the PS*P variable #12

Closed vigoux closed 2 years ago

vigoux commented 2 years ago

This is an attempt to allow customizing the style of predictions.

This is probably implemented badly, and not POSIX.

Thanks for this great shell, I have been searching for this for a long time, and that was the very last thing that bugged me.

vigoux commented 2 years ago

Hi and thanks for reviewing this patch! I am AFK for the weekend but I'll sure handle that after!

PS: I have been working on another patch that changes the cursor shape depending on the mode based on VT510 escape codes, would you be interested in merging it?

magicant commented 2 years ago

Awesome! I'm looking forward to it.

vigoux commented 2 years ago

Hi, I should have addressed your comments now !

magicant commented 2 years ago

Thank you! I'm merging

vigoux commented 2 years ago

Do you want me to change the documentation before merging?

magicant commented 2 years ago

Uh-oh, I've just merged it... f9a6c54

If you are willing to, could you make another pull request for the documentation? If not, don't worry, I'll do the documentation work later. 😸

vigoux commented 2 years ago

As you wish, I can make another PR (or send you the patch by email if that works better for you?)

magicant commented 2 years ago

As you wish, I can make another PR (or send you the patch by email if that works better for you?)

Either is fine, but a PR might be handier for reviewing the patch. Thanks!

magicant commented 1 year ago

@vigoux Hi, I'll soon start updating the documentation. In case you have any work in progress you intend to contribute, please let me know. Thanks!

vigoux commented 1 year ago

Hey, sorry but I did not end up working on it... Sorry about that !

magicant commented 1 year ago

No problem! Thank you for your contribution!