magicbookproject / magicbook

The magic book project returns!
MIT License
1.07k stars 59 forks source link

updates for node.js v18 and Apple Silicon #49

Closed shiffman closed 1 year ago

shiffman commented 1 year ago

I'm working on an M1 Mac now and noticed that magicbook no longer builds properly. I believe these changes will resolve the issues but I'm still testing. Thoughts or feedback or ideas welcome!

I'm still working out how to resolve this error.

Please provide a valid isolate file as the final argument.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! magicbook@0.1.20 benchmark: `cd example && node --prof ../src/index.js build && node --prof-process "$(ls isolate*.log)" > processed.txt && atom processed.txt`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the magicbook@0.1.20 benchmark script.

(I also ran npm audit fix which might have updated some other dependencies)

shiffman commented 1 year ago

Success!!

Screen Shot 2022-10-14 at 2 06 11 PM

@runemadsen does this PDF look like it is supposed to? If so I think this can be merged???

Screen Shot 2022-10-14 at 2 06 40 PM

(Also, note I changed master to main in case you are working with a local clone of the repo.)

runemadsen commented 1 year ago

Yezzzzzzz. You're a master! Let's get it in!

shiffman commented 1 year ago

Yay! What's the process for publishing to npm? Happy to give it a try if you like!

runemadsen commented 1 year ago

I think it's as easy as running npm publish from the root folder (after making sure that the tests pass). I double checked and you're on the list of collaborators for the NPM package, so you should be able to do it. Let me know if you don't!