search

magicbug / Cloudlog

Web based amateur radio logging application built using PHP & MySQL supports general station logging tasks from HF to Microwave with supporting applications to support CAT control.
http://www.cloudlog.co.uk
MIT License
447 stars 189 forks source link

Unable to delete QSL Card #1878

Closed elitegoodguy closed 1 year ago

elitegoodguy commented 1 year ago

This was happening before the 2.3 upgrade however I didn't get a chance to really look into the logs until now.

I uploaded some QSL cards however I accidentally added them to the wrong QSO.

I go to delete and nothing happens. I have also tried to delete via QSO > View QSL > Delete and the same.

I upped the logging level of my CloudLog install and I'm getting the error below everytime I click the delete button.

ERROR - 2022-12-28 20:04:42 --> Severity: error --> Exception: Call to a member function row() on null /var/www/html/application/controllers/Qsl.php 50

phl0 commented 1 year ago

Confirmed there is a bug in the getFilename function.

phl0 commented 1 year ago

And patch is ready: https://github.com/magicbug/Cloudlog/pull/1879.

elitegoodguy commented 1 year ago

Wow that was fast. Took your patch and applied it and is working! Thank you!

Looking forward to contributing to Cloudlog myself.

phl0 commented 1 year ago

Wow that was fast. Took your patch and applied it and is working! Thank you!

Your welcome. Thank you for testing.

Looking forward to contributing to Cloudlog myself.

Always welcome :)

elitegoodguy commented 1 year ago

Closing due to patch was created to fix this issue