magicbug / Cloudlog

Web based amateur radio logging application built using PHP & MySQL supports general station logging tasks from HF to Microwave with supporting applications to support CAT control.
http://www.cloudlog.co.uk
MIT License
456 stars 188 forks source link

php-fpm module hangs when import adif file doesn't terminate correctly #2765

Closed raufaser closed 10 months ago

raufaser commented 11 months ago

Describe the bug php-fpm module hangs when import adif file doesn't terminate correctly

To Reproduce Steps to reproduce the behaviour:

  1. Try to import an adif file with the terminating tag "<e" instead of "

Expected behaviour Error output and stop processing the file

Screenshots

Screenshot 2023-12-02 133449

Server (please complete the following information):

github-actions[bot] commented 11 months ago

Uh oh! @raufaser, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

phl0 commented 11 months ago

Can u please show the (anonymized) part of the ADIF you are trying to import?

raufaser commented 11 months ago

Sure.

WSJT-X ADIF Export<eoh>
<call:6>AB0CDE <gridsquare:0> <mode:3>FT8 <rst_sent:3>-07 <rst_rcvd:3>-09 <qso_date:8>20231201 <time_on:6>162945 <qso_date_off:8>20231201 <time_off:6>162945 <band:3>12m <freq:9>24.917091 <station_callsign:5>ZZ0YXZ <my_gridsquare:6>JO62VM <eor>
<call:6>AC0EDC <gridsquare:4>JO22 <mode:3>FT8 <rst_sent:3>-08 <rst_rcvd:3>-05 <qso_date:8>20231202 <time_on:6>005100 <qso_date_off:8>20231202 <time_off:6>005200 <band:4>160m <freq:8>1.841946 <station_callsign:5>ZZ0YXZ <my_gridsquare:6>JO62VM <e
phl0 commented 10 months ago

Fix proposed with https://github.com/magicbug/Cloudlog/pull/2774. Please close here if this fixed the issue for you as well. Otherwise please comment :) Tnx.