magicdude4eva / port25-bouncehandler

Port25 PowerMTA bounce handler for Interspire and MailWizz
MIT License
73 stars 42 forks source link

Soft bounces being skipped #35

Open computerichy opened 3 years ago

computerichy commented 3 years ago

https://github.com/magicdude4eva/port25-bouncehandler/blob/a6a0b63fde0388674f04203801fe03963f6f6e34/bouncehandler.php#L185

Hey, firstly thanks for sharing this script, it's helped me and I'm sure it has helped others in setting up their mailing system too.

Just thought I'd mention a bug I noticed while testing this on my setup. Maybe I'm missing something, but it seems as though the bounces which fell under the softBounceCategories array were being skipped.

I modified the referenced line to check in both category arrays, and that fixed the issue.

magicdude4eva commented 3 years ago

Thanks for the feedback. Since I changed jobs, I have not used Port25 anymore, but the handling was by design. Only hardbounces should result in an unsubscribe.

I did not want the softbounces result in an unsub, but this obviously depends on your use case and how compliant you want to be. My previous company was on the side of being rather "spammy".