search

magicismight / react-native-root-toast

react native toast like component, pure javascript solution
MIT License
2.08k stars 403 forks source link

Fixed type of message for Toast.show function. #150

Closed AndreasA closed 8 months ago

AndreasA commented 2 years ago

Relates: #123

AndreasA commented 2 years ago

I just found there is annother PR that fixes the type and does some additional stuff regarding ReactNode. https://github.com/magicismight/react-native-root-toast/pull/111

not sure, if the additional stuff is necessary or not because ReactNode seems to already work correctly, except the type, which is why I keep this PR open until feedback by maintainers

gaufranc commented 1 year ago

Can we merge this? thanks