magiclabs / magic-ios

MagicSDK library for IOS
Apache License 2.0
7 stars 7 forks source link

OTP prompt doesn't extend underneath safe areas #37

Open tristan-warner-smith opened 6 months ago

tristan-warner-smith commented 6 months ago

Describe the bug When the OTP is presented on a device with a notch, the content doesn't extend under the safe areas resulting in prominent bars as shown. Shown in dark mode where it's more obvious.

To Reproduce Steps to reproduce the behavior:

  1. Be on a device with a notch, in dark mode ideally
  2. Trigger the OTP screen with magic.auth.loginWithEmailOTP
  3. See the bars

Expected behavior The loaded web view should extend under the safe area and the loaded content should continue to respect the safe area.

Screenshots

Here's the view debugger showing the scrollview, made red. With the subview inside respecting safe area. You can get the subview to extend under the safe areas by adding: contentInsetAdjustmentBehaviour = .never But you'll then need the web content to adjust the close button etc using the css for safe areas

Environment

Additional context Add any other context about the problem here.

Ariflo commented 5 months ago

@tristan-warner-smith is this resolved with your passing a UIViewController here?

tristan-warner-smith commented 5 months ago

@tristan-warner-smith is this resolved with your passing a UIViewController here?

It could be but this is the default, out-of-the-box experience so I think it needs fixing separately. I mentioned before but we aren't doing the work to use the view host yet so the default experience is still this ☝️