search

magiclabs / magic-js

Magic browser/React Native JavaScript SDK is your entry-point to integrating passwordless authentication inside your application.
https://magic.link/docs/api-reference/client-side-sdks/web
Apache License 2.0
463 stars 86 forks source link

Add the Login Form Modal/Overlay to the SDK #281

Closed Adamj1232 closed 1 year ago

Adamj1232 commented 2 years ago

✅ Prerequisites

✨ Feature Request

It would be very helpful to have the Magic Login overlay/modal form found here https://magic.link/docs/login-form I was told through the support chat that it is only available to add through script tag. This wouldnt be a problem except the required data-redirect-uri prop that forces a page change.

🧩 Context

I work at Blocknative and we are working on integrating Magic into our Onboard V2 package. We currently fully support Fortmatic and it would be nice if that same level of SDK support was available through Magic

💻 Examples

https://magic.link/docs/login-form

Screen Shot 2022-02-10 at 11 00 32 AM
techgangboss commented 2 years ago

+1, we have users asking for Magic wallet support and this is a blocker

Adamj1232 commented 2 years ago

Can we revisit this feature request? It would be great if the Magic Login form was exposed through the SDK and didn't require a redirect to allow for users to use all of the login methods without building each one custom. ...Or provide an example of how to use standalone with the SDK without requiring a redirect(i.e. in a standalone modal)

jadbox commented 2 years ago

We'd also be interested in this support!

am-hernandez commented 1 year ago

Hi @Adamj1232 ,

The login form is meant to deliver a no-code/low-code solution. For other projects we have our SDK for which customization is completely open.

A considerable amount of time has passed since this issue was created, would you let me know if you are still interested? This is a fine feature request and although we were not able to add it to our roadmap previously I will raise it again for discussion.