magiclabs / magic-js

Magic browser/React Native JavaScript SDK is your entry-point to integrating passwordless authentication inside your application.
https://magic.link/docs/api-reference/client-side-sdks/web
Apache License 2.0
454 stars 86 forks source link

Magic Connect Instagram Browser Error #541

Open faillacec opened 1 year ago

faillacec commented 1 year ago

✅ Prerequisites

🐛 Description

When try to login with google or email with magic connect it keep loading in auth.magic.link/confirmation-account..

🧩 Steps to Reproduce

  1. Open web app on instagram browser
  2. Try to login with magic using email or google
  3. Magic keep loading in auth.magic.link/confirmation-account..

🤔 Expected behavior

Successfull connection/login

😮 Actual behavior

IMG_0446

💻 Code Sample

🌎 Environment

Software Version(s)
magic-sdk 17.0.0
Browser Instagram browser
yarn NPM
Operating System IOS
joshuascan commented 1 year ago

Hi,

This issue should be resolved as of our most recent update. Can you confirm if you are still encountering it or if it is working correctly now? I am no longer able to reproduce it on my end. Thanks!

faillacec commented 1 year ago

Hi,

This issue should be resolved as of our most recent update. Can you confirm if you are still encountering it or if it is working correctly now? I am no longer able to reproduce it on my end. Thanks!

Hi, I tried login using magic-sdk 17.0.0 and the error persists and I have updated to 18.2.1 version of sdk and the error persists, This happen just after login when I have to sign a message and this open signature in other browser tab, but in-app-browsers don't have tabs and it keep loading https://auth.magic.link/confirm-action

joshuascan commented 1 year ago

Hi,

Sorry, I was incorrect in my first response. So we just released a feature that allows for login with signing in one action, which will mitigate the issue you are encountering. You will need to update to v18.4.1 for it.

The docs for it can be found here, under "Login with wallet verification". ConnectWithUI now emits an event that contains an ID token, which can then be validated in your backend using the admin SDK. The previously mentioned docs contain steps for configuration, along with a demo for the frontend portion.

faillacec commented 1 year ago

Hi,

Sorry, I was incorrect in my first response. So we just released a feature that allows for login with signing in one action, which will mitigate the issue you are encountering. You will need to update to v18.4.1 for it.

The docs for it can be found here, under "Login with wallet verification". ConnectWithUI now emits an event that contains an ID token, which can then be validated in your backend using the admin SDK. The previously mentioned docs contain steps for configuration, along with a demo for the frontend portion.

Hi, Don't worry, but I am not using this kind of signature i am using Personal signature (https://magic.link/docs/connect/features/personal-signatures) this kind of signature open another tab when click on sign