magiclabs / magic-js

Magic browser/React Native JavaScript SDK is your entry-point to integrating passwordless authentication inside your application.
https://magic.link/docs/api-reference/client-side-sdks/web
Apache License 2.0
457 stars 85 forks source link

move crypto-js to dependencies #692

Closed Ethella closed 8 months ago

Ethella commented 8 months ago

📦 Pull Request

Fix webpack 5 build fail for magic-ext/oauth

✅ Fixed Issues

🚨 Test instructions

image

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @magic-ext/oauth@15.4.2-canary.692.7296356209.0 npm install @magic-ext/solana@18.2.2-canary.692.7296356209.0 npm install @magic-sdk/pnp@15.4.2-canary.692.7296356209.0 # or yarn add @magic-ext/oauth@15.4.2-canary.692.7296356209.0 yarn add @magic-ext/solana@18.2.2-canary.692.7296356209.0 yarn add @magic-sdk/pnp@15.4.2-canary.692.7296356209.0 ```
shortcut-integration[bot] commented 8 months ago

This pull request has been linked to Shortcut Story #91626: OAuth Webpack Issue - Common JS - Blocking Decentraland Site Build.

Ariflo commented 8 months ago

:rocket: PR was released in @magic-ext/oauth@15.5.0, @magic-ext/solana@18.3.0, @magic-sdk/pnp@15.5.0 :rocket: