search

magiclabs / magic-js

Magic browser/React Native JavaScript SDK is your entry-point to integrating passwordless authentication inside your application.
https://magic.link/docs/api-reference/client-side-sdks/web
Apache License 2.0
455 stars 85 forks source link

Warn developers of Coming Deprecation of Universal Wallet API Keys #716

Closed Ariflo closed 5 months ago

Ariflo commented 6 months ago

📦 Pull Request

Adds warning to Universal Wallet API Key app developers of impending doom 😈 of Universal Wallet API Keys. We check for product_type to be returned via postMessage after the initial call to /config when we retrieve the theme.

When utilizing a UW API Keys the warning will appear as follows for magic-sdk and all react-native SDK apps:

WARN  Magic SDK Warning: [DEPRECATION_NOTICE] `Usage of Universal Wallet API Keys` will be removed from `@magic-sdk/react-native-bare` in version `v22.0.0`. Use `Dedicated Wallet API Key` instead to prevent disruption of the wallet service.

✅ Fixed Issues

N/A

🚨 Test instructions

Run https://github.com/magiclabs/react-native-demo app locally and follow the instructions set here to test.

Reviewer Notes (Optional)

This PR will work in tandem with https://github.com/magiclabs/phantom/pull/3360

⚠️ Don't forget to add a semver label!

Please only add one label:

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @magic-ext/algorand@17.2.0-canary.716.8026208810.0 npm install @magic-ext/aptos@5.2.0-canary.716.8026208810.0 npm install @magic-ext/avalanche@17.2.0-canary.716.8026208810.0 npm install @magic-ext/bitcoin@17.2.0-canary.716.8026208810.0 npm install @magic-ext/conflux@15.2.0-canary.716.8026208810.0 npm install @magic-ext/cosmos@17.2.0-canary.716.8026208810.0 npm install @magic-ext/ed25519@13.2.0-canary.716.8026208810.0 npm install @magic-ext/flow@17.2.0-canary.716.8026208810.0 npm install @magic-ext/gdkms@5.2.0-canary.716.8026208810.0 npm install @magic-ext/harmony@17.2.0-canary.716.8026208810.0 npm install @magic-ext/icon@17.2.0-canary.716.8026208810.0 npm install @magic-ext/near@17.2.0-canary.716.8026208810.0 npm install @magic-ext/oauth@16.2.0-canary.716.8026208810.0 npm install @magic-ext/oauth2@1.1.0-canary.716.8026208810.0 npm install @magic-ext/oidc@5.2.0-canary.716.8026208810.0 npm install @magic-ext/polkadot@17.2.0-canary.716.8026208810.0 npm install @magic-ext/react-native-bare-oauth@19.2.0-canary.716.8026208810.0 npm install @magic-ext/react-native-expo-oauth@19.2.0-canary.716.8026208810.0 npm install @magic-ext/solana@19.2.0-canary.716.8026208810.0 npm install @magic-ext/taquito@14.2.0-canary.716.8026208810.0 npm install @magic-ext/terra@14.2.0-canary.716.8026208810.0 npm install @magic-ext/tezos@17.2.0-canary.716.8026208810.0 npm install @magic-ext/webauthn@16.2.0-canary.716.8026208810.0 npm install @magic-ext/zilliqa@17.2.0-canary.716.8026208810.0 npm install @magic-sdk/commons@18.2.0-canary.716.8026208810.0 npm install @magic-sdk/pnp@16.2.0-canary.716.8026208810.0 npm install @magic-sdk/provider@22.2.0-canary.716.8026208810.0 npm install @magic-sdk/react-native-bare@23.2.0-canary.716.8026208810.0 npm install @magic-sdk/react-native-expo@23.2.0-canary.716.8026208810.0 npm install @magic-sdk/types@18.2.0-canary.716.8026208810.0 npm install magic-sdk@22.2.0-canary.716.8026208810.0 # or yarn add @magic-ext/algorand@17.2.0-canary.716.8026208810.0 yarn add @magic-ext/aptos@5.2.0-canary.716.8026208810.0 yarn add @magic-ext/avalanche@17.2.0-canary.716.8026208810.0 yarn add @magic-ext/bitcoin@17.2.0-canary.716.8026208810.0 yarn add @magic-ext/conflux@15.2.0-canary.716.8026208810.0 yarn add @magic-ext/cosmos@17.2.0-canary.716.8026208810.0 yarn add @magic-ext/ed25519@13.2.0-canary.716.8026208810.0 yarn add @magic-ext/flow@17.2.0-canary.716.8026208810.0 yarn add @magic-ext/gdkms@5.2.0-canary.716.8026208810.0 yarn add @magic-ext/harmony@17.2.0-canary.716.8026208810.0 yarn add @magic-ext/icon@17.2.0-canary.716.8026208810.0 yarn add @magic-ext/near@17.2.0-canary.716.8026208810.0 yarn add @magic-ext/oauth@16.2.0-canary.716.8026208810.0 yarn add @magic-ext/oauth2@1.1.0-canary.716.8026208810.0 yarn add @magic-ext/oidc@5.2.0-canary.716.8026208810.0 yarn add @magic-ext/polkadot@17.2.0-canary.716.8026208810.0 yarn add @magic-ext/react-native-bare-oauth@19.2.0-canary.716.8026208810.0 yarn add @magic-ext/react-native-expo-oauth@19.2.0-canary.716.8026208810.0 yarn add @magic-ext/solana@19.2.0-canary.716.8026208810.0 yarn add @magic-ext/taquito@14.2.0-canary.716.8026208810.0 yarn add @magic-ext/terra@14.2.0-canary.716.8026208810.0 yarn add @magic-ext/tezos@17.2.0-canary.716.8026208810.0 yarn add @magic-ext/webauthn@16.2.0-canary.716.8026208810.0 yarn add @magic-ext/zilliqa@17.2.0-canary.716.8026208810.0 yarn add @magic-sdk/commons@18.2.0-canary.716.8026208810.0 yarn add @magic-sdk/pnp@16.2.0-canary.716.8026208810.0 yarn add @magic-sdk/provider@22.2.0-canary.716.8026208810.0 yarn add @magic-sdk/react-native-bare@23.2.0-canary.716.8026208810.0 yarn add @magic-sdk/react-native-expo@23.2.0-canary.716.8026208810.0 yarn add @magic-sdk/types@18.2.0-canary.716.8026208810.0 yarn add magic-sdk@22.2.0-canary.716.8026208810.0 ```
svc-magic-git commented 5 months ago

:rocket: PR was released in @magic-ext/algorand@23.0.0, @magic-ext/aptos@11.0.0, @magic-ext/avalanche@23.0.0, @magic-ext/bitcoin@23.0.0, @magic-ext/conflux@21.0.0, @magic-ext/cosmos@23.0.0, @magic-ext/ed25519@19.0.0, @magic-ext/flow@23.0.0, @magic-ext/gdkms@11.0.0, @magic-ext/harmony@23.0.0, @magic-ext/icon@23.0.0, @magic-ext/near@23.0.0, @magic-ext/oauth2@9.0.0, @magic-ext/oauth@22.0.0, @magic-ext/oidc@11.0.0, @magic-ext/polkadot@23.0.0, @magic-ext/react-native-bare-oauth@25.0.0, @magic-ext/react-native-expo-oauth@25.0.0, @magic-ext/solana@25.0.0, @magic-ext/taquito@20.0.0, @magic-ext/terra@20.0.0, @magic-ext/tezos@23.0.0, @magic-ext/webauthn@22.0.0, @magic-ext/zilliqa@23.0.0, @magic-sdk/commons@24.0.0, @magic-sdk/pnp@22.0.0, @magic-sdk/provider@28.0.0, @magic-sdk/react-native-bare@29.0.0, @magic-sdk/react-native-expo@29.0.0, @magic-sdk/types@24.0.0, magic-sdk@28.0.0 :rocket: