magiclabs / magic-js

Magic browser/React Native JavaScript SDK is your entry-point to integrating passwordless authentication inside your application.
https://magic.link/docs/api-reference/client-side-sdks/web
Apache License 2.0
455 stars 85 forks source link

Bug Report: Endless Cookie Rendering Loop #733

Open Adebesin-Cell opened 5 months ago

Adebesin-Cell commented 5 months ago

โœ… Prerequisites

๐Ÿ› Description

Upon initializing the Wagmi connector into my project, I noticed a peculiar behavior related to cookie rendering.

๐Ÿงฉ Steps to Reproduce

  1. Integrate the Wagmi connector into the project.
  2. Initialize the Wagmi connector within the codebase.
  3. Observe the rendering behavior of cookies.
  4. Notice the continuous rendering of cookies without halt.

๐Ÿค” Expected behavior

I expected the cookies to render appropriately upon initialization and to cease rendering once initialized. There should be no continuous loop of cookie rendering.

๐Ÿ˜ฎ Actual behavior

The cookies enter an infinite rendering loop, continually rendering without cessation. This behavior triggers an error marked with number of times it has rendered, indicating that the cookies have been rendered an excessive number of times. Consequently, this error warns that third-party cookie functionality may be blocked.

๐Ÿ’ป Code Sample

https://stackblitz.com/edit/stackblitz-starters-bbb65e?file=app%2Fpage.tsx,app%2Fconfig.ts,package.json

Screenshots

Screenshot 2024-03-25 at 5 38 25 PM

๐ŸŒŽ Environment

Software Version(s)
magic-sdk 18.3.0
Browser Vivaldi
yarn >=1.22.0
Operating System Mac OS Ventura 13.1 (22C65)
Royal-lobster commented 4 months ago

This seems to be a issue on almost all sites that has magic login integrations

image

image image image
hubagaspar91 commented 4 months ago

Yep, we're experiencing this issue as well, we recently upgraded https://github.com/magiclabs/wagmi-magic-connector in our project from 1.1.5 to 2.0.0, which it seems also comes with a magic SDK version upgrade.

TheGreatAlgo commented 3 months ago

Having same issue too. we were on 8.1.0 (time for upgrade lol) and having the issue

mjafri118 commented 2 months ago

is there a fix to this? upgrading does not seem to help.

Wyxuch commented 1 month ago

Hi there! this bug still occurring in 28.0.7. Is there any chance to fix that in the upcoming updates?