magiclabs / magic-js

Magic browser/React Native JavaScript SDK is your entry-point to integrating passwordless authentication inside your application.
https://magic.link/docs/api-reference/client-side-sdks/web
Apache License 2.0
455 stars 85 forks source link

fix: iOS async popup #753

Closed ysm-dev closed 1 month ago

ysm-dev commented 2 months ago

📦 Pull Request

[Provide a general summary of the pull request here.]

Fix iOS Async popup (ref: https://www.lexo.ch/blog/2021/08/fix-how-to-use-window-open-in-safari-inside-async-call/#:~:text=Safari%20blocks%20any%20window.,that%20a%20popup%20gets%20blocked.)

✅ Fixed Issues

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @magic-ext/farcaster@0.0.4-canary.753.9641783511.0 # or yarn add @magic-ext/farcaster@0.0.4-canary.753.9641783511.0 ```
svc-magic-git commented 1 month ago

:rocket: PR was released in @magic-ext/farcaster@0.0.4 :rocket: