search

magiclabs / magic-js

Magic browser/React Native JavaScript SDK is your entry-point to integrating passwordless authentication inside your application.
https://magic.link/docs/api-reference/client-side-sdks/web
Apache License 2.0
455 stars 85 forks source link

Fix: consider the provider ready after 15s even if the message hasn't arrived #760

Closed romin-halltari closed 1 month ago

romin-halltari commented 1 month ago

📦 Pull Request

We expect the overlay to be ready within 15 seconds. Sometimes the message is not properly processed due to webview issues. In that case, after 15 seconds we consider the overlay ready, to avoid requests hanging forever.

✅ Fixed Issues

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @magic-ext/algorand@23.1.0-canary.760.9898019531.0 npm install @magic-ext/aptos@11.1.0-canary.760.9898019531.0 npm install @magic-ext/avalanche@23.1.0-canary.760.9898019531.0 npm install @magic-ext/bitcoin@23.1.0-canary.760.9898019531.0 npm install @magic-ext/conflux@21.1.0-canary.760.9898019531.0 npm install @magic-ext/cosmos@23.1.0-canary.760.9898019531.0 npm install @magic-ext/ed25519@19.1.0-canary.760.9898019531.0 npm install @magic-ext/farcaster@0.1.0-canary.760.9898019531.0 npm install @magic-ext/flow@23.1.0-canary.760.9898019531.0 npm install @magic-ext/gdkms@11.1.0-canary.760.9898019531.0 npm install @magic-ext/harmony@23.1.0-canary.760.9898019531.0 npm install @magic-ext/icon@23.1.0-canary.760.9898019531.0 npm install @magic-ext/near@23.1.0-canary.760.9898019531.0 npm install @magic-ext/oauth@22.1.0-canary.760.9898019531.0 npm install @magic-ext/oauth2@9.1.0-canary.760.9898019531.0 npm install @magic-ext/oidc@11.1.0-canary.760.9898019531.0 npm install @magic-ext/polkadot@23.1.0-canary.760.9898019531.0 npm install @magic-ext/react-native-bare-oauth@25.1.0-canary.760.9898019531.0 npm install @magic-ext/react-native-expo-oauth@25.1.0-canary.760.9898019531.0 npm install @magic-ext/solana@25.2.0-canary.760.9898019531.0 npm install @magic-ext/sui@0.2.0-canary.760.9898019531.0 npm install @magic-ext/taquito@20.1.0-canary.760.9898019531.0 npm install @magic-ext/terra@20.1.0-canary.760.9898019531.0 npm install @magic-ext/tezos@23.1.0-canary.760.9898019531.0 npm install @magic-ext/webauthn@22.1.0-canary.760.9898019531.0 npm install @magic-ext/zilliqa@23.1.0-canary.760.9898019531.0 npm install @magic-sdk/commons@24.1.0-canary.760.9898019531.0 npm install @magic-sdk/pnp@22.1.0-canary.760.9898019531.0 npm install @magic-sdk/provider@28.1.0-canary.760.9898019531.0 npm install @magic-sdk/react-native-bare@29.1.0-canary.760.9898019531.0 npm install @magic-sdk/react-native-expo@29.1.0-canary.760.9898019531.0 npm install magic-sdk@28.1.0-canary.760.9898019531.0 # or yarn add @magic-ext/algorand@23.1.0-canary.760.9898019531.0 yarn add @magic-ext/aptos@11.1.0-canary.760.9898019531.0 yarn add @magic-ext/avalanche@23.1.0-canary.760.9898019531.0 yarn add @magic-ext/bitcoin@23.1.0-canary.760.9898019531.0 yarn add @magic-ext/conflux@21.1.0-canary.760.9898019531.0 yarn add @magic-ext/cosmos@23.1.0-canary.760.9898019531.0 yarn add @magic-ext/ed25519@19.1.0-canary.760.9898019531.0 yarn add @magic-ext/farcaster@0.1.0-canary.760.9898019531.0 yarn add @magic-ext/flow@23.1.0-canary.760.9898019531.0 yarn add @magic-ext/gdkms@11.1.0-canary.760.9898019531.0 yarn add @magic-ext/harmony@23.1.0-canary.760.9898019531.0 yarn add @magic-ext/icon@23.1.0-canary.760.9898019531.0 yarn add @magic-ext/near@23.1.0-canary.760.9898019531.0 yarn add @magic-ext/oauth@22.1.0-canary.760.9898019531.0 yarn add @magic-ext/oauth2@9.1.0-canary.760.9898019531.0 yarn add @magic-ext/oidc@11.1.0-canary.760.9898019531.0 yarn add @magic-ext/polkadot@23.1.0-canary.760.9898019531.0 yarn add @magic-ext/react-native-bare-oauth@25.1.0-canary.760.9898019531.0 yarn add @magic-ext/react-native-expo-oauth@25.1.0-canary.760.9898019531.0 yarn add @magic-ext/solana@25.2.0-canary.760.9898019531.0 yarn add @magic-ext/sui@0.2.0-canary.760.9898019531.0 yarn add @magic-ext/taquito@20.1.0-canary.760.9898019531.0 yarn add @magic-ext/terra@20.1.0-canary.760.9898019531.0 yarn add @magic-ext/tezos@23.1.0-canary.760.9898019531.0 yarn add @magic-ext/webauthn@22.1.0-canary.760.9898019531.0 yarn add @magic-ext/zilliqa@23.1.0-canary.760.9898019531.0 yarn add @magic-sdk/commons@24.1.0-canary.760.9898019531.0 yarn add @magic-sdk/pnp@22.1.0-canary.760.9898019531.0 yarn add @magic-sdk/provider@28.1.0-canary.760.9898019531.0 yarn add @magic-sdk/react-native-bare@29.1.0-canary.760.9898019531.0 yarn add @magic-sdk/react-native-expo@29.1.0-canary.760.9898019531.0 yarn add magic-sdk@28.1.0-canary.760.9898019531.0 ```
svc-magic-git commented 1 month ago

:rocket: PR was released in @magic-ext/algorand@23.1.0, @magic-ext/aptos@11.1.0, @magic-ext/avalanche@23.1.0, @magic-ext/bitcoin@23.1.0, @magic-ext/conflux@21.1.0, @magic-ext/cosmos@23.1.0, @magic-ext/ed25519@19.1.0, @magic-ext/farcaster@0.1.0, @magic-ext/flow@23.1.0, @magic-ext/gdkms@11.1.0, @magic-ext/harmony@23.1.0, @magic-ext/icon@23.1.0, @magic-ext/near@23.1.0, @magic-ext/oauth2@9.1.0, @magic-ext/oauth@22.1.0, @magic-ext/oidc@11.1.0, @magic-ext/polkadot@23.1.0, @magic-ext/react-native-bare-oauth@25.1.0, @magic-ext/react-native-expo-oauth@25.1.0, @magic-ext/solana@25.2.0, @magic-ext/sui@0.2.0, @magic-ext/taquito@20.1.0, @magic-ext/terra@20.1.0, @magic-ext/tezos@23.1.0, @magic-ext/webauthn@22.1.0, @magic-ext/zilliqa@23.1.0, @magic-sdk/commons@24.1.0, @magic-sdk/pnp@22.1.0, @magic-sdk/provider@28.1.0, @magic-sdk/react-native-bare@29.1.0, @magic-sdk/react-native-expo@29.1.0, magic-sdk@28.1.0 :rocket: