magiclabs / magic-js

Magic browser/React Native JavaScript SDK is your entry-point to integrating passwordless authentication inside your application.
https://magic.link/docs/api-reference/client-side-sdks/web
Apache License 2.0
463 stars 86 forks source link

Enable whitelabel customization for sms login #768

Closed khamdam-magic closed 2 months ago

khamdam-magic commented 3 months ago

📦 Pull Request

✅ Fixed Issues

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @magic-ext/algorand@23.6.0-canary.768.10579617213.0 npm install @magic-ext/aptos@11.6.0-canary.768.10579617213.0 npm install @magic-ext/avalanche@23.6.0-canary.768.10579617213.0 npm install @magic-ext/bitcoin@23.6.0-canary.768.10579617213.0 npm install @magic-ext/conflux@21.6.0-canary.768.10579617213.0 npm install @magic-ext/cosmos@23.6.0-canary.768.10579617213.0 npm install @magic-ext/ed25519@19.6.0-canary.768.10579617213.0 npm install @magic-ext/farcaster@0.6.0-canary.768.10579617213.0 npm install @magic-ext/flow@23.6.0-canary.768.10579617213.0 npm install @magic-ext/gdkms@11.6.0-canary.768.10579617213.0 npm install @magic-ext/harmony@23.6.0-canary.768.10579617213.0 npm install @magic-ext/icon@23.6.0-canary.768.10579617213.0 npm install @magic-ext/near@23.6.0-canary.768.10579617213.0 npm install @magic-ext/oauth@22.6.0-canary.768.10579617213.0 npm install @magic-ext/oauth2@9.6.0-canary.768.10579617213.0 npm install @magic-ext/oidc@11.6.0-canary.768.10579617213.0 npm install @magic-ext/polkadot@23.6.0-canary.768.10579617213.0 npm install @magic-ext/react-native-bare-oauth@25.6.0-canary.768.10579617213.0 npm install @magic-ext/react-native-expo-oauth@25.6.0-canary.768.10579617213.0 npm install @magic-ext/solana@25.7.0-canary.768.10579617213.0 npm install @magic-ext/sui@0.7.0-canary.768.10579617213.0 npm install @magic-ext/taquito@20.6.0-canary.768.10579617213.0 npm install @magic-ext/terra@20.6.0-canary.768.10579617213.0 npm install @magic-ext/tezos@23.6.0-canary.768.10579617213.0 npm install @magic-ext/webauthn@22.6.0-canary.768.10579617213.0 npm install @magic-ext/zilliqa@23.6.0-canary.768.10579617213.0 npm install @magic-sdk/commons@24.6.0-canary.768.10579617213.0 npm install @magic-sdk/pnp@22.6.0-canary.768.10579617213.0 npm install @magic-sdk/provider@28.6.0-canary.768.10579617213.0 npm install @magic-sdk/react-native-bare@29.6.0-canary.768.10579617213.0 npm install @magic-sdk/react-native-expo@29.6.0-canary.768.10579617213.0 npm install @magic-sdk/types@24.4.0-canary.768.10579617213.0 npm install magic-sdk@28.6.0-canary.768.10579617213.0 # or yarn add @magic-ext/algorand@23.6.0-canary.768.10579617213.0 yarn add @magic-ext/aptos@11.6.0-canary.768.10579617213.0 yarn add @magic-ext/avalanche@23.6.0-canary.768.10579617213.0 yarn add @magic-ext/bitcoin@23.6.0-canary.768.10579617213.0 yarn add @magic-ext/conflux@21.6.0-canary.768.10579617213.0 yarn add @magic-ext/cosmos@23.6.0-canary.768.10579617213.0 yarn add @magic-ext/ed25519@19.6.0-canary.768.10579617213.0 yarn add @magic-ext/farcaster@0.6.0-canary.768.10579617213.0 yarn add @magic-ext/flow@23.6.0-canary.768.10579617213.0 yarn add @magic-ext/gdkms@11.6.0-canary.768.10579617213.0 yarn add @magic-ext/harmony@23.6.0-canary.768.10579617213.0 yarn add @magic-ext/icon@23.6.0-canary.768.10579617213.0 yarn add @magic-ext/near@23.6.0-canary.768.10579617213.0 yarn add @magic-ext/oauth@22.6.0-canary.768.10579617213.0 yarn add @magic-ext/oauth2@9.6.0-canary.768.10579617213.0 yarn add @magic-ext/oidc@11.6.0-canary.768.10579617213.0 yarn add @magic-ext/polkadot@23.6.0-canary.768.10579617213.0 yarn add @magic-ext/react-native-bare-oauth@25.6.0-canary.768.10579617213.0 yarn add @magic-ext/react-native-expo-oauth@25.6.0-canary.768.10579617213.0 yarn add @magic-ext/solana@25.7.0-canary.768.10579617213.0 yarn add @magic-ext/sui@0.7.0-canary.768.10579617213.0 yarn add @magic-ext/taquito@20.6.0-canary.768.10579617213.0 yarn add @magic-ext/terra@20.6.0-canary.768.10579617213.0 yarn add @magic-ext/tezos@23.6.0-canary.768.10579617213.0 yarn add @magic-ext/webauthn@22.6.0-canary.768.10579617213.0 yarn add @magic-ext/zilliqa@23.6.0-canary.768.10579617213.0 yarn add @magic-sdk/commons@24.6.0-canary.768.10579617213.0 yarn add @magic-sdk/pnp@22.6.0-canary.768.10579617213.0 yarn add @magic-sdk/provider@28.6.0-canary.768.10579617213.0 yarn add @magic-sdk/react-native-bare@29.6.0-canary.768.10579617213.0 yarn add @magic-sdk/react-native-expo@29.6.0-canary.768.10579617213.0 yarn add @magic-sdk/types@24.4.0-canary.768.10579617213.0 yarn add magic-sdk@28.6.0-canary.768.10579617213.0 ```
Ethella commented 3 months ago

Overall looks gud, but we should get mandrake changes merged first then merge this.

khamdam-magic commented 3 months ago

@Ethella I updated types here which are used in mandrake. So should we first merge this and then update sdk/type version in mandrake ?

svc-magic-git commented 2 months ago

:rocket: PR was released in @magic-ext/algorand@23.6.0, @magic-ext/aptos@11.6.0, @magic-ext/avalanche@23.6.0, @magic-ext/bitcoin@23.6.0, @magic-ext/conflux@21.6.0, @magic-ext/cosmos@23.6.0, @magic-ext/ed25519@19.6.0, @magic-ext/farcaster@0.6.0, @magic-ext/flow@23.6.0, @magic-ext/gdkms@11.6.0, @magic-ext/harmony@23.6.0, @magic-ext/icon@23.6.0, @magic-ext/near@23.6.0, @magic-ext/oauth2@9.6.0, @magic-ext/oauth@22.6.0, @magic-ext/oidc@11.6.0, @magic-ext/polkadot@23.6.0, @magic-ext/react-native-bare-oauth@25.6.0, @magic-ext/react-native-expo-oauth@25.6.0, @magic-ext/solana@25.7.0, @magic-ext/sui@0.7.0, @magic-ext/taquito@20.6.0, @magic-ext/terra@20.6.0, @magic-ext/tezos@23.6.0, @magic-ext/webauthn@22.6.0, @magic-ext/zilliqa@23.6.0, @magic-sdk/commons@24.6.0, @magic-sdk/pnp@22.6.0, @magic-sdk/provider@28.6.0, @magic-sdk/react-native-bare@29.6.0, @magic-sdk/react-native-expo@29.6.0, @magic-sdk/types@24.4.0, magic-sdk@28.6.0 :rocket: