Open pkosiec opened 5 years ago
Confirm these statements before you submit the issue:
Description
Hi @magicmatatjahu, First of all: Great tool!
I have an idea for simplifying the whitelist config. Currently we have:
- path: "path" config: white-list-internal: ["./test.md"] white-list-external: ["https://foo.bar"]
Can't we have just whitelist key?
whitelist
- path: "path" config: whitelist: ["./test.md", "https://foo.bar"]
Sometimes we have false positives, which we doesn't know whether they are classified as internal or external links.
Thanks!
Hi @pkosiec Thanks you for using milv tool. I want to do something similar to what you proposed, but in version 0.1.0. For now, I do not have much time to do that, but If you want, feel welcome to contribute. :)
Confirm these statements before you submit the issue:
[x] I have read the contributing guidelines.
Description
Hi @magicmatatjahu, First of all: Great tool!
I have an idea for simplifying the whitelist config. Currently we have:
Can't we have just
whitelist
key?Sometimes we have false positives, which we doesn't know whether they are classified as internal or external links.
Thanks!