search

magicmatatjahu / milv

Markdown internal & external links validation library and CLI
MIT License
11 stars 5 forks source link

Simplify whitelist config #10

Open pkosiec opened 5 years ago

pkosiec commented 5 years ago

Confirm these statements before you submit the issue:

Description

Hi @magicmatatjahu, First of all: Great tool!

I have an idea for simplifying the whitelist config. Currently we have:

  - path: "path"
    config:
      white-list-internal: ["./test.md"]
      white-list-external: ["https://foo.bar"]

Can't we have just whitelist key?

  - path: "path"
    config:
      whitelist: ["./test.md", "https://foo.bar"]

Sometimes we have false positives, which we doesn't know whether they are classified as internal or external links.

Thanks!

magicmatatjahu commented 5 years ago

Hi @pkosiec Thanks you for using milv tool. I want to do something similar to what you proposed, but in version 0.1.0. For now, I do not have much time to do that, but If you want, feel welcome to contribute. :)